Commit d8861011 authored by Peter Xu's avatar Peter Xu Committed by Markus Armbruster
Browse files

chardev: comment details for CLOSED event 



It was unclear before on what does the CLOSED event mean.  Meanwhile we
add a TODO to fix up the CLOSED event in the future when the in/out
ports are different for a chardev.

CC: Paolo Bonzini <pbonzini@redhat.com>
CC: "Marc-André Lureau" <marcandre.lureau@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
Message-Id: <20180620073223.31964-2-peterx@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 6f4fa099

include/chardev/char.h

+10 −1
Original line number Diff line number Diff line
@@ -22,7 +22,16 @@ typedef enum { 
    CHR_EVENT_OPENED, /* new connection established */

    CHR_EVENT_MUX_IN, /* mux-focus was set to this terminal */

    CHR_EVENT_MUX_OUT, /* mux-focus will move on */

    CHR_EVENT_CLOSED /* connection closed */

    CHR_EVENT_CLOSED /* connection closed.  NOTE: currently this event

                      * is only bound to the read port of the chardev.

                      * Normally the read port and write port of a

                      * chardev should be the same, but it can be

                      * different, e.g., for fd chardevs, when the two

                      * fds are different.  So when we received the

                      * CLOSED event it's still possible that the out

                      * port is still open.  TODO: we should only send

                      * the CLOSED event when both ports are closed.

                      */

} QEMUChrEvent;



#define CHR_READ_BUF_LEN 4096