Commit d3b0db6d authored by Alexander Graf's avatar Alexander Graf Committed by Gerd Hoffmann
Browse files

vnc: Set default kbd delay to 10ms 



The current VNC default keyboard delay is 1ms. With that we're constantly
typing faster than the guest receives keyboard events from an XHCI attached
USB HID device.

The default keyboard delay time in the input layer however is 10ms. I don't know
how that number came to be, but empirical tests on some OpenQA driven ARM
systems show that 10ms really is a reasonable default number for the delay.

This patch moves the VNC delay also to 10ms. That way our default is much
safer (good!) and also consistent with the input layer default (also good!).

Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Message-id: 1499863425-103133-1-git-send-email-agraf@suse.de
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 6e2c4633

qemu-options.hx

+1 −1
Original line number Diff line number Diff line
@@ -1753,7 +1753,7 @@ spec but is traditional QEMU behavior. 
@item key-delay-ms



Set keyboard delay, for key down and key up events, in milliseconds.

Default is 1.  Keyboards are low-bandwidth devices, so this slowdown

Default is 10.  Keyboards are low-bandwidth devices, so this slowdown

can help the device and guest to keep up and not lose events in case

events are arriving in bulk.  Possible causes for the latter are flaky

network connections, or scripts for automated testing.

ui/vnc.c

+1 −1
Original line number Diff line number Diff line
@@ -3808,7 +3808,7 @@ void vnc_display_open(const char *id, Error **errp) 
    }



    lock_key_sync = qemu_opt_get_bool(opts, "lock-key-sync", true);

    key_delay_ms = qemu_opt_get_number(opts, "key-delay-ms", 1);

    key_delay_ms = qemu_opt_get_number(opts, "key-delay-ms", 10);

    sasl = qemu_opt_get_bool(opts, "sasl", false);

#ifndef CONFIG_VNC_SASL

    if (sasl) {