Commit cdcf1405 authored by Stefan Weil's avatar Stefan Weil Committed by Peter Maydell
Browse files

target-arm: Fix bit test in sp_el0_access 



Static code analyzers complain about a dubious & operation used for a
boolean value. The code does not test the PSTATE_SP bit as it should.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
Message-id: 1406359601-25583-1-git-send-email-sw@weilnetz.de
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 63b60551

target-arm/helper.c

+1 −1
Original line number Diff line number Diff line
@@ -1853,7 +1853,7 @@ static uint64_t aa64_dczid_read(CPUARMState *env, const ARMCPRegInfo *ri) 


static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri)

{

    if (!env->pstate & PSTATE_SP) {

    if (!(env->pstate & PSTATE_SP)) {

        /* Access to SP_EL0 is undefined if it's being used as

         * the stack pointer.

         */