Commit be1927c9 authored by Jan Kiszka's avatar Jan Kiszka Committed by Michael S. Tsirkin
Browse files

ioapic: kvm: Skip route updates for masked pins 



Masked entries will not generate interrupt messages, thus do no need to
be routed by KVM. This is a cosmetic cleanup, just avoiding warnings of
the kind

qemu-system-x86_64: vtd_irte_get: detected non-present IRTE (index=0, high=0xff00, low=0x100)

if the masked entry happens to reference a non-present IRTE.

Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Message-Id: <a84b7e03-f9a8-b577-be27-4d93d1caa1c9@siemens.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
parent 21e2acd5

hw/intc/ioapic.c

+5 −3
Original line number Diff line number Diff line
@@ -197,10 +197,12 @@ static void ioapic_update_kvm_routes(IOAPICCommonState *s) 
            MSIMessage msg;

            struct ioapic_entry_info info;

            ioapic_entry_parse(s->ioredtbl[i], &info);

            if (!info.masked) {

                msg.address = info.addr;

                msg.data = info.data;

                kvm_irqchip_update_msi_route(kvm_state, i, msg, NULL);

            }

        }

        kvm_irqchip_commit_routes(kvm_state);

    }

#endif