Commit 21e2acd5 authored by Evgeny Yakovlev's avatar Evgeny Yakovlev Committed by Michael S. Tsirkin
Browse files

i386/acpi: fix gint overflow in crs_range_compare 



When very large regions (32GB sized in our case, PCI pass-through of GPUs)
are compared substraction result does not fit into gint.

As a result crs_replace_with_free_ranges does not get sorted ranges and
incorrectly computes PCI64 free space regions. Which then makes linux
guest complain about device and PCI64 hole intersection and device
becomes unusable.

Fix that by returning exactly fitting ranges.

Also fix indentation of an entire crs_replace_with_free_ranges to make
checkpatch happy.

Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarEvgeny Yakovlev <wrfsh@yandex-team.ru>
Message-Id: <1563466463-26012-1-git-send-email-wrfsh@yandex-team.ru>
Signed-off-by: default avatarEvgeny Yakovlev <wrfsh@yandex-team.ru>
parent df98d7cc

hw/i386/acpi-build.c

+9 −3
Original line number Diff line number Diff line
@@ -758,7 +758,13 @@ static gint crs_range_compare(gconstpointer a, gconstpointer b) 
    CrsRangeEntry *entry_a = *(CrsRangeEntry **)a;

    CrsRangeEntry *entry_b = *(CrsRangeEntry **)b;



     return (int64_t)entry_a->base - (int64_t)entry_b->base;

    if (entry_a->base < entry_b->base) {

        return -1;

    } else if (entry_a->base > entry_b->base) {

        return 1;

    } else {

        return 0;

    }

}



/*