Commit baca6f18 authored by Anthony Liguori's avatar Anthony Liguori
Browse files

char-socket: fix error reporting 



Right now the inet connect code tries all available addresses but until one
doesn't fail.  It passes local_err each time without clearing it from the
previous failure.  This can trigger an assert since the inet connect code
tries to set an error on an object != NULL.

Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Message-id: 16c806d60aa5e9660ed7751bb4e37dcd278f97f0.1362505276.git.amit.shah@redhat.com
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 0bc472a9

util/qemu-sockets.c

+4 −0
Original line number Diff line number Diff line
@@ -373,6 +373,10 @@ int inet_connect_opts(QemuOpts *opts, Error **errp, 
    }



    for (e = res; e != NULL; e = e->ai_next) {

        if (error_is_set(errp)) {

            error_free(*errp);

            *errp = NULL;

        }

        if (connect_state != NULL) {

            connect_state->current_addr = e;

        }