Commit b57b3368 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE 



We forgot to propagate the highest bit accross the high doubleword in
two cases (shift >=64).

Fixes: 5f724887 ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC")
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20191021085715.3797-4-david@redhat.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 8b952519

target/s390x/vec_int_helper.c

+4 −2
Original line number Diff line number Diff line
@@ -70,15 +70,17 @@ static void s390_vec_sar(S390Vector *d, const S390Vector *a, uint64_t count) 
        d->doubleword[0] = a->doubleword[0];

        d->doubleword[1] = a->doubleword[1];

    } else if (count == 64) {

        tmp = (int64_t)a->doubleword[0] >> 63;

        d->doubleword[1] = a->doubleword[0];

        d->doubleword[0] = 0;

        d->doubleword[0] = tmp;

    } else if (count < 64) {

        tmp = a->doubleword[1] >> count;

        d->doubleword[1] = deposit64(tmp, 64 - count, count, a->doubleword[0]);

        d->doubleword[0] = (int64_t)a->doubleword[0] >> count;

    } else {

        tmp = (int64_t)a->doubleword[0] >> 63;

        d->doubleword[1] = (int64_t)a->doubleword[0] >> (count - 64);

        d->doubleword[0] = 0;

        d->doubleword[0] = tmp;

    }

}