Commit aa09a485 authored by Thomas Huth's avatar Thomas Huth Committed by Jason Wang
Browse files

net: Make net_client_init() static 



The function is only used within net.c, so there's no need that
this is a global function.

While we're at it, also remove the unused prototype compute_mcast_idx()
(the function has been removed in commit d9caeb09).

Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 253dc14c

include/net/net.h

+0 −2
Original line number Diff line number Diff line
@@ -204,7 +204,6 @@ extern const char *host_net_devices[]; 
extern const char *legacy_tftp_prefix;

extern const char *legacy_bootp_filename;



int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp);

int net_client_parse(QemuOptsList *opts_list, const char *str);

int net_init_clients(Error **errp);

void net_check_clients(void);
@@ -228,7 +227,6 @@ void qdev_set_nic_properties(DeviceState *dev, NICInfo *nd); 
#define POLYNOMIAL_LE 0xedb88320

uint32_t net_crc32(const uint8_t *p, int len);

uint32_t net_crc32_le(const uint8_t *p, int len);

unsigned compute_mcast_idx(const uint8_t *ep);



#define vmstate_offset_macaddr(_state, _field)                       \

    vmstate_offset_array(_state, _field.a, uint8_t,                \

net/net.c

+1 −1
Original line number Diff line number Diff line
@@ -1119,7 +1119,7 @@ static void show_netdevs(void) 
    }

}



int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)

static int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)

{

    void *object = NULL;

    Error *err = NULL;