Commit 9e5bef49 authored by David Hildenbrand's avatar David Hildenbrand Committed by Richard Henderson
Browse files

s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in probe_write_access() 



If I'm not completely wrong, we are dealing with guest addresses here
and not with host addresses. Use the right check.

Fixes: c5a7392c ("s390x/tcg: Provide probe_write_access helper")
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Message-Id: <20190826075112.25637-2-david@redhat.com>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent 03a98189

target/s390x/mem_helper.c

+1 −1
Original line number Diff line number Diff line
@@ -2616,7 +2616,7 @@ void probe_write_access(CPUS390XState *env, uint64_t addr, uint64_t len, 
                        uintptr_t ra)

{

#ifdef CONFIG_USER_ONLY

    if (!h2g_valid(addr) || !h2g_valid(addr + len - 1) ||

    if (!guest_addr_valid(addr) || !guest_addr_valid(addr + len - 1) ||

        page_check_range(addr, len, PAGE_WRITE) < 0) {

        s390_program_interrupt(env, PGM_ADDRESSING, ILEN_AUTO, ra);

    }