Commit 9d70c4b7 authored by Max Filippov's avatar Max Filippov Committed by Blue Swirl
Browse files

exec: fix TB invalidation after breakpoint insertion/deletion 



tb_invalidate_phys_addr has to be called with the exact physical address of
the breakpoint we add/remove, not just the page's base address.
Otherwise we easily fail to flush the right TB.

This breakage was introduced by the commit f3705d53 "memory: make
phys_page_find() return an unadjusted".

This appeared to work for some guest architectures because their
cpu_get_phys_page_debug implementation returns full translated physical
address, not just the base of the TARGET_PAGE_SIZE-sized page.

Reported-by: default avatarTeLeMan <geleman@gmail.com>
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
parent c305e32f

exec.c

+2 −1
Original line number Diff line number Diff line
@@ -1492,7 +1492,8 @@ void tb_invalidate_phys_addr(target_phys_addr_t addr) 


static void breakpoint_invalidate(CPUArchState *env, target_ulong pc)

{

    tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc));

    tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc) |

            (pc & ~TARGET_PAGE_MASK));

}

#endif

#endif /* TARGET_HAS_ICE */