Commit 9a6d74c0 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Gerd Hoffmann
Browse files

virtio-gpu: remove useless 'waiting' field 



Let's check renderer_blocked instead directly.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20190221114330.17968-5-marcandre.lureau@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent ad341aac

hw/display/virtio-gpu.c

+1 −3
Original line number Diff line number Diff line
@@ -889,8 +889,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g) 
    while (!QTAILQ_EMPTY(&g->cmdq)) {

        cmd = QTAILQ_FIRST(&g->cmdq);



        cmd->waiting = g->renderer_blocked;

        if (cmd->waiting) {

        if (g->renderer_blocked) {

            break;

        }
@@ -939,7 +938,6 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq) 
        cmd->vq = vq;

        cmd->error = 0;

        cmd->finished = false;

        cmd->waiting = false;

        QTAILQ_INSERT_TAIL(&g->cmdq, cmd, next);

        cmd = virtqueue_pop(vq, sizeof(struct virtio_gpu_ctrl_command));

    }

include/hw/virtio/virtio-gpu.h

+0 −1
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ struct virtio_gpu_ctrl_command { 
    VirtQueue *vq;

    struct virtio_gpu_ctrl_hdr cmd_hdr;

    uint32_t error;

    bool waiting;

    bool finished;

    QTAILQ_ENTRY(virtio_gpu_ctrl_command) next;

};