Commit 92b540da authored by Thomas Huth's avatar Thomas Huth Committed by Paolo Bonzini
Browse files

tests/boot-serial-test: Make sure that we check the timeout regularly 



If the guest continuesly writes characters to the UART, we never leave
the inner while loop and thus never check whether we've reached the
timeout value. So if we fail to find the expected string in the UART
output, the test just hangs and never finishs. Use a counter to regularly
break out of the while loop to check the timeout.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Message-Id: <1512031988-32490-2-git-send-email-thuth@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent cfcca361

tests/boot-serial-test.c

+3 −2
Original line number Diff line number Diff line
@@ -43,12 +43,13 @@ static testdef_t tests[] = { 
static void check_guest_output(const testdef_t *test, int fd)

{

    bool output_ok = false;

    int i, nbr, pos = 0;

    int i, nbr, pos = 0, ccnt;

    char ch;



    /* Poll serial output... Wait at most 60 seconds */

    for (i = 0; i < 6000; ++i) {

        while ((nbr = read(fd, &ch, 1)) == 1) {

        ccnt = 0;

        while ((nbr = read(fd, &ch, 1)) == 1 && ccnt++ < 512) {

            if (ch == test->expect[pos]) {

                pos += 1;

                if (test->expect[pos] == '\0') {