Commit 7fe4a41c authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

vnc: fix segfault 



Commit "c7628bff vnc: only alloc server surface with clients connected"
missed one rarely used codepath (cirrus with guest drivers using 2d
accel) where we have to check for the server surface being present,
to avoid qemu crashing with a NULL pointer dereference.  Add the check.

Reported-by: default avatarAnthony PERARD <anthony.perard@citrix.com>
Tested-by: default avatarAnthony PERARD <anthony.perard@citrix.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 4b6eda62

ui/vnc.c

+5 −0
Original line number Diff line number Diff line
@@ -931,6 +931,11 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl, 
    int i, x, y, pitch, inc, w_lim, s;

    int cmp_bytes;



    if (!vd->server) {

        /* no client connected */

        return;

    }



    vnc_refresh_server_surface(vd);

    QTAILQ_FOREACH_SAFE(vs, &vd->clients, next, vn) {

        if (vnc_has_feature(vs, VNC_FEATURE_COPYRECT)) {