Commit c7628bff authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

vnc: only alloc server surface with clients connected



Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reviewed-by: default avatarPeter Lieven <pl@kamp.de>
Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Message-id: 1446203414-4013-15-git-send-email-kraxel@redhat.com
parent f7b3d68c
Loading
Loading
Loading
Loading
+12 −0
Original line number Diff line number Diff line
@@ -731,6 +731,10 @@ static void vnc_update_server_surface(VncDisplay *vd)
    qemu_pixman_image_unref(vd->server);
    vd->server = NULL;

    if (QTAILQ_EMPTY(&vd->clients)) {
        return;
    }

    vd->server = pixman_image_create_bits(VNC_SERVER_FB_FORMAT,
                                          vnc_width(vd),
                                          vnc_height(vd),
@@ -1241,6 +1245,10 @@ void vnc_disconnect_finish(VncState *vs)
    if (vs->initialized) {
        QTAILQ_REMOVE(&vs->vd->clients, vs, next);
        qemu_remove_mouse_mode_change_notifier(&vs->mouse_mode_notifier);
        if (QTAILQ_EMPTY(&vs->vd->clients)) {
            /* last client gone */
            vnc_update_server_surface(vs->vd);
        }
    }

    if (vs->vd->lock_key_sync)
@@ -3079,6 +3087,7 @@ void vnc_init_state(VncState *vs)
{
    vs->initialized = true;
    VncDisplay *vd = vs->vd;
    bool first_client = QTAILQ_EMPTY(&vd->clients);

    vs->last_x = -1;
    vs->last_y = -1;
@@ -3092,6 +3101,9 @@ void vnc_init_state(VncState *vs)
    vs->bh = qemu_bh_new(vnc_jobs_bh, vs);

    QTAILQ_INSERT_TAIL(&vd->clients, vs, next);
    if (first_client) {
        vnc_update_server_surface(vd);
    }

    graphic_hw_update(vd->dcl.con);