Commit 7fa0ddc1 authored by Anton Blanchard's avatar Anton Blanchard Committed by David Gibson
Browse files

target/ppc: Fix vsum2sws 



A recent cleanup changed the pre zeroing of the result from 64 bit
to 32 bit operations:

-        result.u64[i] = 0;
+        result.VsrW(i) = 0;

This corrupts the result.

Fixes: 60594fea ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in int_helper.c")
Signed-off-by: default avatarAnton Blanchard <anton@ozlabs.org>
Message-Id: <20190507004811.29968-9-anton@ozlabs.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 63be02fc

target/ppc/int_helper.c

+1 −1
Original line number Diff line number Diff line
@@ -2053,7 +2053,7 @@ void helper_vsum2sws(CPUPPCState *env, ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) 
    for (i = 0; i < ARRAY_SIZE(r->u64); i++) {

        int64_t t = (int64_t)b->VsrSW(upper + i * 2);



        result.VsrW(i) = 0;

        result.VsrD(i) = 0;

        for (j = 0; j < ARRAY_SIZE(r->u64); j++) {

            t += a->VsrSW(2 * i + j);

        }