Commit 63be02fc authored by Anton Blanchard's avatar Anton Blanchard Committed by David Gibson
Browse files

target/ppc: Fix vslv and vsrv 



vslv and vsrv are broken on little endian, we append 00 to the
high byte not the low byte. Fix it by using the VsrB() accessor.

Signed-off-by: default avatarAnton Blanchard <anton@ozlabs.org>
Message-Id: <20190507004811.29968-6-anton@ozlabs.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent d47a751a

target/ppc/int_helper.c

+7 −7
Original line number Diff line number Diff line
@@ -1815,10 +1815,10 @@ void helper_vslv(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) 


    size = ARRAY_SIZE(r->u8);

    for (i = 0; i < size; i++) {

        shift = b->u8[i] & 0x7;             /* extract shift value */

        bytes = (a->u8[i] << 8) +             /* extract adjacent bytes */

            (((i + 1) < size) ? a->u8[i + 1] : 0);

        r->u8[i] = (bytes << shift) >> 8;   /* shift and store result */

        shift = b->VsrB(i) & 0x7;             /* extract shift value */

        bytes = (a->VsrB(i) << 8) +           /* extract adjacent bytes */

            (((i + 1) < size) ? a->VsrB(i + 1) : 0);

        r->VsrB(i) = (bytes << shift) >> 8;   /* shift and store result */

    }

}
@@ -1833,10 +1833,10 @@ void helper_vsrv(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) 
     * order will guarantee that computed result is not fed back.

     */

    for (i = ARRAY_SIZE(r->u8) - 1; i >= 0; i--) {

        shift = b->u8[i] & 0x7;                 /* extract shift value */

        bytes = ((i ? a->u8[i - 1] : 0) << 8) + a->u8[i];

        shift = b->VsrB(i) & 0x7;               /* extract shift value */

        bytes = ((i ? a->VsrB(i - 1) : 0) << 8) + a->VsrB(i);

                                                /* extract adjacent bytes */

        r->u8[i] = (bytes >> shift) & 0xFF;     /* shift and store result */

        r->VsrB(i) = (bytes >> shift) & 0xFF;   /* shift and store result */

    }

}