Commit 75c5626c authored by Alex Williamson's avatar Alex Williamson Committed by Michael S. Tsirkin
Browse files

intel_iommu: Correct caching-mode error message 



If we try to use the intel-iommu device with vfio-pci devices without
caching mode enabled, we're told:

  qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable
  device assignment with IOMMU protection.

But to enable caching mode, the option is actually "caching-mode=on".

Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Message-Id: <155364147432.16467.15898335025013220939.stgit@gimli.home>
Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
Reviewed-by: default avatarLaurent Vivier <laurent@vivier.eu>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarAlex Williamson &amp;lt;&lt;a href="mailto:alex.williamson@redhat.com" target="_blank" <rel="noreferrer"&gt;alex.williamson@redhat.com&lt;/a&gt;&amp;gt;&lt;br>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 22132828

hw/i386/intel_iommu.c

+1 −1
Original line number Diff line number Diff line
@@ -2919,7 +2919,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu, 
    IntelIOMMUState *s = vtd_as->iommu_state;



    if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {

        error_report("We need to set caching-mode=1 for intel-iommu to enable "

        error_report("We need to set caching-mode=on for intel-iommu to enable "

                     "device assignment with IOMMU protection.");

        exit(1);

    }