Commit 22132828 authored by Liam Merwick's avatar Liam Merwick Committed by Michael S. Tsirkin
Browse files

acpi: verify file entries in bios_linker_loader_add_pointer() 



The callers to bios_linker_find_file() assert that the file entry returned
is not NULL, except for those in bios_linker_loader_add_pointer().  Add two
asserts in that case for completeness and to facilitate static code analysis.

Signed-off-by: default avatarLiam Merwick <liam.merwick@oracle.com>
Message-Id: <1553199229-25318-1-git-send-email-liam.merwick@oracle.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 436960c9

hw/acpi/bios-linker-loader.c

+2 −0
Original line number Diff line number Diff line
@@ -283,6 +283,8 @@ void bios_linker_loader_add_pointer(BIOSLinker *linker, 
    const BiosLinkerFileEntry *source_file =

        bios_linker_find_file(linker, src_file);



    assert(dst_file);

    assert(source_file);

    assert(dst_patched_offset < dst_file->blob->len);

    assert(dst_patched_offset + dst_patched_size <= dst_file->blob->len);

    assert(src_offset < source_file->blob->len);