Commit 74f38e96 authored by Igor Mammedov's avatar Igor Mammedov Committed by Eduardo Habkost
Browse files

numa: clarify error message when node index is out of range in -numa dist, ... 



When using following CLI:
  -numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
   "Invalid node 128, max possible could be 128"

Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Message-Id: <1526483174-169008-1-git-send-email-imammedo@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent e609fa71

numa.c

+2 −3
Original line number Diff line number Diff line
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp) 
    uint8_t val = dist->val;



    if (src >= MAX_NODES || dst >= MAX_NODES) {

        error_setg(errp,

                   "Invalid node %d, max possible could be %d",

                   MAX(src, dst), MAX_NODES);

        error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",

                   src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);

        return;

    }