Commit 71195672 authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

target-i386: Remove ABM from qemu64 CPU model 



ABM is not available on Sandy Bridge and older, and we want to make the
default CPU runnable in most hosts, so it won't be enabled by default in
KVM mode.

We should eventually have all features supported by TCG enabled by
default in TCG mode, but as we don't have a good mechanism today to
ensure we have different defaults in KVM and TCG mode, disable ABM in
the qemu64 CPU model entirely.

Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 0909ad24

include/hw/i386/pc.h

+5 −0
Original line number Diff line number Diff line
@@ -332,6 +332,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); 
            .driver   = "qemu64" "-" TYPE_X86_CPU,\

            .property = "sse4a",\

            .value    = "on",\

        },\

        {\

            .driver   = "qemu64" "-" TYPE_X86_CPU,\

            .property = "abm",\

            .value    = "on",\

        },



#define PC_COMPAT_2_3 \

target-i386/cpu.c

+1 −2
Original line number Diff line number Diff line
@@ -675,8 +675,7 @@ static X86CPUDefinition builtin_x86_defs[] = { 
        .features[FEAT_8000_0001_EDX] =

            CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,

        .features[FEAT_8000_0001_ECX] =

            CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |

            CPUID_EXT3_ABM,

            CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM,

        .xlevel = 0x8000000A,

    },

    {