Commit 0909ad24 authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

target-i386: Remove SSE4a from qemu64 CPU model 



SSE4a is not available in any Intel CPU, and we want to make the default
CPU runnable in most hosts, so it doesn't make sense to enable it by
default in KVM mode.

We should eventually have all features supported by TCG enabled by
default in TCG mode, but as we don't have a good mechanism today to
ensure we have different defaults in KVM and TCG mode, disable SSE4a in
the qemu64 CPU model entirely.

Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 3e684822

include/hw/i386/pc.h

+5 −0
Original line number Diff line number Diff line
@@ -327,6 +327,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); 
            .driver   = TYPE_X86_CPU,\

            .property = "check",\

            .value    = "off",\

        },\

        {\

            .driver   = "qemu64" "-" TYPE_X86_CPU,\

            .property = "sse4a",\

            .value    = "on",\

        },



#define PC_COMPAT_2_3 \

target-i386/cpu.c

+1 −1
Original line number Diff line number Diff line
@@ -676,7 +676,7 @@ static X86CPUDefinition builtin_x86_defs[] = { 
            CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,

        .features[FEAT_8000_0001_ECX] =

            CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |

            CPUID_EXT3_ABM | CPUID_EXT3_SSE4A,

            CPUID_EXT3_ABM,

        .xlevel = 0x8000000A,

    },

    {