Commit 5bb8b739 authored by Yuval Shaia's avatar Yuval Shaia Committed by Marcel Apfelbaum
Browse files

hw/pvrdma: Make function pvrdma_qp_send/recv return void. 



The functions handles errors internaly, callers have nothing to do with
the return value.

Signed-off-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Message-Id: <20190109202140.4051-1-yuval.shaia@oracle.com>
Reviewed-by: default avatarMarcel <Apfelbaum&lt;marcel.apfelbaum@gmail.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarMarcel Apfelbaum <marcel.apfelbaum@gmail.com>
parent 26fd8695

hw/rdma/vmw/pvrdma_qp_ops.c

+6 −8
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ int pvrdma_qp_ops_init(void) 
    return 0;

}



int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)

void pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)

{

    RdmaRmQP *qp;

    PvrdmaSqWqe *wqe;
@@ -155,7 +155,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) 


    qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle);

    if (unlikely(!qp)) {

        return -EINVAL;

        pr_dbg("Invalid qpn\n");

        return;

    }



    ring = (PvrdmaRing *)qp->opaque;
@@ -212,11 +213,9 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) 


        wqe = pvrdma_ring_next_elem_read(ring);

    }



    return 0;

}



int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle)

void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle)

{

    RdmaRmQP *qp;

    PvrdmaRqWqe *wqe;
@@ -226,7 +225,8 @@ int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) 


    qp = rdma_rm_get_qp(&dev->rdma_dev_res, qp_handle);

    if (unlikely(!qp)) {

        return -EINVAL;

        pr_dbg("Invalid qpn\n");

        return;

    }



    ring = &((PvrdmaRing *)qp->opaque)[1];
@@ -262,8 +262,6 @@ int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) 


        wqe = pvrdma_ring_next_elem_read(ring);

    }



    return 0;

}



void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle)

hw/rdma/vmw/pvrdma_qp_ops.h

+2 −2
Original line number Diff line number Diff line
@@ -20,8 +20,8 @@ 


int pvrdma_qp_ops_init(void);

void pvrdma_qp_ops_fini(void);

int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle);

int pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle);

void pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle);

void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle);

void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle);



#endif