Commit 26fd8695 authored by Yuval Shaia's avatar Yuval Shaia Committed by Marcel Apfelbaum
Browse files

hw/pvrdma: Post CQE when receive invalid gid index 



This error should propagate back to guest.

Spotted by Coverity: CID 1398595

Fixes: 2b05705d

Reported-by: default avatarLi Qiang <liq3ea@163.com>
Signed-off-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: default avatarMarcel Apfelbaum <marcel.apfelbaum@gmail.com>
parent 732d948c

hw/rdma/rdma_backend.h

+1 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
#define VENDOR_ERR_INVLKEY          0x207

#define VENDOR_ERR_MR_SMALL         0x208

#define VENDOR_ERR_INV_MAD_BUFF     0x209

#define VENDOR_ERR_INV_GID_IDX      0x210



/* Add definition for QP0 and QP1 as there is no userspace enums for them */

enum ibv_special_qp_type {

hw/rdma/vmw/pvrdma_qp_ops.c

+4 −2
Original line number Diff line number Diff line
@@ -178,7 +178,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) 
        sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);

        if (!sgid) {

            pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);

            return -EIO;

            complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);

            continue;

        }

        pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,

               sgid->global.interface_id);
@@ -189,7 +190,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) 
        if (sgid_idx <= 0) {

            pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",

                   wqe->hdr.wr.ud.av.gid_index);

            return -EIO;

            complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);

            continue;

        }



        if (wqe->hdr.num_sge > dev->dev_attr.max_sge) {