Commit 57b6bdf3 authored by Benoît Canet's avatar Benoît Canet Committed by Stefan Hajnoczi
Browse files

blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close. 



As bdrv_open() documentation states:
"The reference to the QDict belongs to the block layer
 * after the call (even on failure), so if the caller intends to reuse the
 * dictionary, it needs to use QINCREF() before calling bdrv_open."

the optional options dict will not be reused after bdrv_open() and should
belong to the block layer so remove the extra QDECREF(options).

Signed-off-by: default avatarBenoit Canet <benoit@irqsave.net>
Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent cc67f4d1

blockdev.c

+0 −2
Original line number Diff line number Diff line
@@ -1329,8 +1329,6 @@ static void external_snapshot_prepare(BlkTransactionState *common, 
    if (ret != 0) {

        error_propagate(errp, local_err);

    }



    QDECREF(options);

}



static void external_snapshot_commit(BlkTransactionState *common)