Commit 56faeb9b authored by Peter Maydell's avatar Peter Maydell Committed by Jeff Cody
Browse files

block/gluster.c: Handle qdict_array_entries() failure 



In qemu_gluster_parse_json(), the call to qdict_array_entries()
could return a negative error code, which we were ignoring
because we assigned the result to an unsigned variable.
Fix this by using the 'int' type instead, which matches the
return type of qdict_array_entries() and also the type
we use for the loop enumeration variable 'i'.

(Spotted by Coverity, CID 1360960.)

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Message-id: 1496682098-1540-1-git-send-email-peter.maydell@linaro.org
Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
parent 64175afc

block/gluster.c

+1 −2
Original line number Diff line number Diff line
@@ -493,8 +493,7 @@ static int qemu_gluster_parse_json(BlockdevOptionsGluster *gconf, 
    Error *local_err = NULL;

    char *str = NULL;

    const char *ptr;

    size_t num_servers;

    int i, type;

    int i, type, num_servers;



    /* create opts info from runtime_json_opts list */

    opts = qemu_opts_create(&runtime_json_opts, NULL, 0, &error_abort);