Commit 499748d7 authored by Richard Henderson's avatar Richard Henderson Committed by Peter Maydell
Browse files

tcg: Restrict check_size_impl to multiples of the line size 



Normally this is automatic in the size restrictions that are placed
on vector sizes coming from the implementation.  However, for the
legitimate size tuple [oprsz=8, maxsz=32], we need to clear the final
24 bytes of the vector register.  Without this check, do_dup selects
TCG_TYPE_V128 and clears only 16 bytes.

Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Tested-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-id: 20180705191929.30773-2-richard.henderson@linaro.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 2f95a3b0

tcg/tcg-op-gvec.c

+5 −2
Original line number Diff line number Diff line
@@ -287,9 +287,12 @@ void tcg_gen_gvec_4_ptr(uint32_t dofs, uint32_t aofs, uint32_t bofs, 
   in units of LNSZ.  This limits the expansion of inline code.  */

static inline bool check_size_impl(uint32_t oprsz, uint32_t lnsz)

{

    if (oprsz % lnsz == 0) {

        uint32_t lnct = oprsz / lnsz;

        return lnct >= 1 && lnct <= MAX_UNROLL;

    }

    return false;

}



static void expand_clr(uint32_t dofs, uint32_t maxsz);