Commit 3d74ee7d authored by Peter Maydell's avatar Peter Maydell Committed by Michael Tokarev
Browse files

lm32: milkymist-tmu2: fix a third integer overflow 



Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.

This fixes a similar coverity warning to commits 237a8650 and
4382fa65, in a similar way, and is the final third of the fix for
coverity CID 1167561 (hopefully!).

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: default avatarMichael Walle <michael@walle.cc>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 79cad2fa

hw/display/milkymist-tmu2.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static void tmu2_start(MilkymistTMU2State *s) 
    cpu_physical_memory_unmap(mesh, mesh_len, 0, mesh_len);



    /* Write back the OpenGL framebuffer to the QEMU framebuffer */

    fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];

    fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];

    fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 1);

    if (fb == NULL) {

        glDeleteTextures(1, &texture);