Commit 237a8650 authored by Michael Walle's avatar Michael Walle Committed by Michael Tokarev
Browse files

lm32: milkymist-tmu2: fix integer overflow 



Don't truncate the multiplication and do a 64 bit one instead because
because the result is stored in a 64 bit variable.

Spotted by coverity, CID 1167561.

Signed-off-by: default avatarMichael Walle <michael@walle.cc>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 19f846b1

hw/display/milkymist-tmu2.c

+1 −1
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ static void tmu2_start(MilkymistTMU2State *s) 
    /* Read the QEMU source framebuffer into an OpenGL texture */

    glGenTextures(1, &texture);

    glBindTexture(GL_TEXTURE_2D, texture);

    fb_len = 2*s->regs[R_TEXHRES]*s->regs[R_TEXVRES];

    fb_len = 2ULL * s->regs[R_TEXHRES] * s->regs[R_TEXVRES];

    fb = cpu_physical_memory_map(s->regs[R_TEXFBUF], &fb_len, 0);

    if (fb == NULL) {

        glDeleteTextures(1, &texture);