Commit 2285a00c authored by Jan Kiszka's avatar Jan Kiszka Committed by Jason Wang
Browse files

e1000e: Do not auto-clear ICR bits which aren't set in EIAC 



The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when
E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the
issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid
receiver overrun interrupt bursts") and was worked around by
745d0bd3af99 ("e1000e: Remove Other from EIAC").

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 8b43f964

hw/net/e1000e_core.c

+0 −4
Original line number Diff line number Diff line
@@ -2022,10 +2022,6 @@ e1000e_msix_notify_one(E1000ECore *core, uint32_t cause, uint32_t int_cfg) 


    effective_eiac = core->mac[EIAC] & cause;



    if (effective_eiac == E1000_ICR_OTHER) {

        effective_eiac |= E1000_ICR_OTHER_CAUSES;

    }



    core->mac[ICR] &= ~effective_eiac;



    if (!(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) {