Commit 8b43f964 authored by Lin Ma's avatar Lin Ma Committed by Jason Wang
Browse files

net: Fix a potential segfault 



If user forgets to provide any backend types for '-netdev' in qemu CLI,
It triggers seg fault.

e.g.

Expected:
$ qemu -netdev id=net0
qemu-system-x86_64: Parameter 'type' is missing

Actual:
$ qemu -netdev id=net0
Segmentation fault (core dumped)

Fixes: 547203ea ("net: List available netdevs with "-netdev help")
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarLin Ma <lma@suse.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent d542800d

net/net.c

+3 −1
Original line number Diff line number Diff line
@@ -1093,7 +1093,9 @@ static int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp) 
    int ret = -1;

    Visitor *v = opts_visitor_new(opts);



    if (is_netdev && is_help_option(qemu_opt_get(opts, "type"))) {

    const char *type = qemu_opt_get(opts, "type");



    if (is_netdev && type && is_help_option(type)) {

        show_netdevs();

        exit(0);

    } else {