Commit 2209401f authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Paolo Bonzini
Browse files

qdev: fix use-after-free regression from becdfa00 



Spotted by Coverity, CID 1365383.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161107095922.31676-1-marcandre.lureau@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 51227875

hw/core/qdev-properties-system.c

+2 −6
Original line number Diff line number Diff line
@@ -200,18 +200,14 @@ static void set_chr(Object *obj, Visitor *v, const char *name, void *opaque, 
    }



    s = qemu_chr_find(str);

    g_free(str);

    if (s == NULL) {

        error_setg(errp, "Property '%s.%s' can't find value '%s'",

                   object_get_typename(obj), prop->name, str);

        return;

    }



    if (!qemu_chr_fe_init(be, s, errp)) {

    } else if (!qemu_chr_fe_init(be, s, errp)) {

        error_prepend(errp, "Property '%s.%s' can't take value '%s': ",

                      object_get_typename(obj), prop->name, str);

        return;

    }

    g_free(str);

}



static void release_chr(Object *obj, const char *name, void *opaque)