Commit 1a5a5570 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé
Browse files

hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses 



The Plug & Play region of the AHB/APB bridge can be accessed
by various word size, however the implementation is clearly
restricted to 32-bit:

  static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
  {
      AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque);

      return ahb_pnp->regs[offset >> 2];
  }

Similarly to commit 0fbe394a with the APB PnP registers,
set the MemoryRegionOps::impl min/max fields to 32-bit, so
memory.c::access_with_adjusted_size() can adjust when the
access is not 32-bit.

Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarKONRAD Frederic <frederic.konrad@adacore.com>
Message-Id: <20200331105048.27989-4-f4bug@amsat.org>
parent bb15013e

hw/misc/grlib_ahb_apb_pnp.c

+4 −0
Original line number Diff line number Diff line
@@ -146,6 +146,10 @@ static const MemoryRegionOps grlib_ahb_pnp_ops = { 
    .read       = grlib_ahb_pnp_read,

    .write      = grlib_ahb_pnp_write,

    .endianness = DEVICE_BIG_ENDIAN,

    .impl = {

        .min_access_size = 4,

        .max_access_size = 4,

    },

};



static void grlib_ahb_pnp_realize(DeviceState *dev, Error **errp)