Commit 0fbe394a authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Laurent Vivier
Browse files

hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses 



The Plug & Play region of the AHB/APB bridge can be accessed
by various word size, however the implementation is clearly
restricted to 32-bit:

  static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned size)
  {
      APBPnp *apb_pnp = GRLIB_APB_PNP(opaque);

      return apb_pnp->regs[offset >> 2];
  }

Set the MemoryRegionOps::impl min/max fields to 32-bit, so
memory.c::access_with_adjusted_size() can adjust when the
access is not 32-bit.

This is required to run RTEMS on leon3, the grlib scanning
functions do byte accesses.

Reported-by: default avatarJiri Gaisler <jiri@gaisler.se>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarKONRAD Frederic <frederic.konrad@adacore.com>
Message-Id: <20191025110114.27091-3-philmd@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent 158b6594

hw/misc/grlib_ahb_apb_pnp.c

+4 −0
Original line number Diff line number Diff line
@@ -242,6 +242,10 @@ static const MemoryRegionOps grlib_apb_pnp_ops = { 
    .read       = grlib_apb_pnp_read,

    .write      = grlib_apb_pnp_write,

    .endianness = DEVICE_BIG_ENDIAN,

    .impl = {

        .min_access_size = 4,

        .max_access_size = 4,

    },

};



static void grlib_apb_pnp_realize(DeviceState *dev, Error **errp)