Commit 0ef705a2 authored May 05, 2015 by Cole Robinson Committed by Gerd Hoffmann May 20, 2015

qemu-sockets: Report explicit error if unlink fails



Consider this case:

$ ls -ld ~/root-owned/
drwx--x--x. 2 root root 4096 Apr 29 12:55 /home/crobinso/root-owned/
$ ls -l ~/root-owned/foo.sock
-rwxrwxrwx. 1 crobinso crobinso 0 Apr 29 12:55 /home/crobinso/root-owned/foo.sock

$ qemu-system-x86_64 -vnc unix:~/root-owned/foo.sock
qemu-system-x86_64: -vnc unix:/home/crobinso/root-owned/foo.sock: Failed to start VNC server: Failed to bind socket to /home/crobinso/root-owned/foo.sock: Address already in use

...which is techinically true, but the real error is that we failed to
unlink. So report it.

This may seem pathological but it's a real possibility via libvirt.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent bc119048

util/qemu-sockets.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -729,7 +729,12 @@ int unix_listen_opts(QemuOpts opts, Error *errp)
		qemu_opt_set(opts, "path", un.sun_path, &error_abort);
		}

		unlink(un.sun_path);
		if ((access(un.sun_path, F_OK) == 0) &&
		unlink(un.sun_path) < 0) {
		error_setg_errno(errp, errno,
		"Failed to unlink socket %s", un.sun_path);
		goto err;
		}
		if (bind(sock, (struct sockaddr*) &un, sizeof(un)) < 0) {
		error_setg_errno(errp, errno, "Failed to bind socket to %s", un.sun_path);
		goto err;