Commit bc119048 authored by Cole Robinson's avatar Cole Robinson Committed by Gerd Hoffmann
Browse files

vnc: Tweak error when init fails 



Before:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied

After:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server: Failed to bind socket to /root/foo.sock: Permission denied

Rather than tweak the string possibly show unix: value as well,
just drop the explicit display reporting. We already get the cli
string in the error message, that should be sufficient.

Signed-off-by: default avatarCole Robinson <crobinso@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 3d00ac1a

ui/vnc.c

+1 −2
Original line number Diff line number Diff line
@@ -3779,8 +3779,7 @@ int vnc_init_func(QemuOpts *opts, void *opaque) 
    vnc_display_init(id);

    vnc_display_open(id, &local_err);

    if (local_err != NULL) {

        error_report("Failed to start VNC server on `%s': %s",

                     qemu_opt_get(opts, "display"),

        error_report("Failed to start VNC server: %s",

                     error_get_pretty(local_err));

        error_free(local_err);

        exit(1);