Commit 09a333ee authored by Peter Maydell's avatar Peter Maydell Committed by David Gibson
Browse files

hw/ppc/ppc440_uc: Remove dead code in sdram_size() 



Coverity points out in CID 1390588 that the test for sh == 0
in sdram_size() can never fire, because we calculate sh with
    sh = 1024 - ((bcr >> 6) & 0x3ff);
which must result in a value between 1 and 1024 inclusive.

Without the relevant manual for the SoC, we're not completely
sure of the correct behaviour here, but we can remove the
dead code without changing how QEMU currently behaves.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarLaurent Vivier <lvivier@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent bba8e23a

hw/ppc/ppc440_uc.c

+1 −5
Original line number Diff line number Diff line
@@ -559,11 +559,7 @@ static target_ulong sdram_size(uint32_t bcr) 
    int sh;



    sh = 1024 - ((bcr >> 6) & 0x3ff);

    if (sh == 0) {

        size = -1;

    } else {

    size = 8 * MiB * sh;

    }



    return size;

}