Skip to content
Commit f981bf6b authored by H.J. Lu's avatar H.J. Lu
Browse files

parse_fdinfo: Don't advance pointer twice [BZ #31798]



pidfd_getpid.c has

      /* Ignore invalid large values.  */
      if (INT_MULTIPLY_WRAPV (10, n, &n)
          || INT_ADD_WRAPV (n, *l++ - '0', &n))
        return -1;

For GCC older than GCC 7, INT_ADD_WRAPV(a, b, r) is defined as

   _GL_INT_OP_WRAPV (a, b, r, +, _GL_INT_ADD_RANGE_OVERFLOW)

and *l++ - '0' is evaluated twice.  Fix BZ #31798 by moving "l++" out of
the if statement.  Tested with GCC 6.4 and GCC 14.1.

Signed-off-by: default avatarH.J. Lu <hjl.tools@gmail.com>
Reviewed-by: default avatarAdhemerval Zanella <adhemerval.zanella@linaro.org>
parent ab46c6ba
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment