Skip to content
  1. May 04, 2023
    • Horatio Zhang's avatar
      drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v10_0_hw_fini · 08c677cb
      Horatio Zhang authored
      
      
      The gmc.ecc_irq is enabled by firmware per IFWI setting,
      and the host driver is not privileged to enable/disable
      the interrupt. So, it is meaningless to use the amdgpu_irq_put
      function in gmc_v10_0_hw_fini, which also leads to the call
      trace.
      
      [   82.340264] Call Trace:
      [   82.340265]  <TASK>
      [   82.340269]  gmc_v10_0_hw_fini+0x83/0xa0 [amdgpu]
      [   82.340447]  gmc_v10_0_suspend+0xe/0x20 [amdgpu]
      [   82.340623]  amdgpu_device_ip_suspend_phase2+0x127/0x1c0 [amdgpu]
      [   82.340789]  amdgpu_device_ip_suspend+0x3d/0x80 [amdgpu]
      [   82.340955]  amdgpu_device_pre_asic_reset+0xdd/0x2b0 [amdgpu]
      [   82.341122]  amdgpu_device_gpu_recover.cold+0x4dd/0xbb2 [amdgpu]
      [   82.341359]  amdgpu_debugfs_reset_work+0x4c/0x70 [amdgpu]
      [   82.341529]  process_one_work+0x21d/0x3f0
      [   82.341535]  worker_thread+0x1fa/0x3c0
      [   82.341538]  ? process_one_work+0x3f0/0x3f0
      [   82.341540]  kthread+0xff/0x130
      [   82.341544]  ? kthread_complete_and_exit+0x20/0x20
      [   82.341547]  ret_from_fork+0x22/0x30
      
      Signed-off-by: default avatarHoratio Zhang <Hongkun.Zhang@amd.com>
      Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
      Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
      Fixes: c8b5a95b ("drm/amdgpu: Fix desktop freezed after gpu-reset")
      Cc: stable@vger.kernel.org
      08c677cb
    • Horatio Zhang's avatar
      drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini · 13af5561
      Horatio Zhang authored
      
      
      The gmc.ecc_irq is enabled by firmware per IFWI setting,
      and the host driver is not privileged to enable/disable
      the interrupt. So, it is meaningless to use the amdgpu_irq_put
      function in gmc_v11_0_hw_fini, which also leads to the call
      trace.
      
      [  102.980303] Call Trace:
      [  102.980303]  <TASK>
      [  102.980304]  gmc_v11_0_hw_fini+0x54/0x90 [amdgpu]
      [  102.980357]  gmc_v11_0_suspend+0xe/0x20 [amdgpu]
      [  102.980409]  amdgpu_device_ip_suspend_phase2+0x240/0x460 [amdgpu]
      [  102.980459]  amdgpu_device_ip_suspend+0x3d/0x80 [amdgpu]
      [  102.980520]  amdgpu_device_pre_asic_reset+0xd9/0x490 [amdgpu]
      [  102.980573]  amdgpu_device_gpu_recover.cold+0x548/0xce6 [amdgpu]
      [  102.980687]  amdgpu_debugfs_reset_work+0x4c/0x70 [amdgpu]
      [  102.980740]  process_one_work+0x21f/0x3f0
      [  102.980741]  worker_thread+0x200/0x3e0
      [  102.980742]  ? process_one_work+0x3f0/0x3f0
      [  102.980743]  kthread+0xfd/0x130
      [  102.980743]  ? kthread_complete_and_exit+0x20/0x20
      [  102.980744]  ret_from_fork+0x22/0x30
      
      Signed-off-by: default avatarHoratio Zhang <Hongkun.Zhang@amd.com>
      Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
      Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
      Fixes: c8b5a95b ("drm/amdgpu: Fix desktop freezed after gpu-reset")
      Cc: stable@vger.kernel.org
      13af5561
    • Shane Xiao's avatar
      drm/amdgpu: Enable doorbell selfring after resize FB BAR · b03f38b9
      Shane Xiao authored
      
      
      [Why]
      The selfring doorbell aperture will change when resize FB
      BAR successfully during gmc sw init, we should reorder
      the sequence of enabling doorbell selfring aperture.
      
      [How]
      Move enable_doorbell_selfring_aperture from *_common_hw_init
      to *_common_late_init.
      
      This fixes the potential issue that GPU ring its own
      doorbell when this device is in translated mode when
      iommu is on.
      
      v2: Remove *_enable_doorbell_aperture functions (Christian)
      v3: Add comments to note that why we need enable doorbell
          selfring late (Christian)
      
      Signed-off-by: default avatarShane Xiao <shane.xiao@amd.com>
      Signed-off-by: default avatarAaron Liu <aaron.liu@amd.com>
      Tested-by: default avatarXiaomeng Hou <Xiaomeng.Hou@amd.com>
      Reviewed-by: default avatarChristian K�nig <christian.koenig@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      b03f38b9
    • lyndonli's avatar
      drm/amdgpu: Use the default reset when loading or reloading the driver · 4eea7fb9
      lyndonli authored
      
      
      Below call trace and errors are observed when reloading
      amdgpu driver with the module parameter reset_method=3.
      
      It should do a default reset when loading or reloading the
      driver, regardless of the module parameter reset_method.
      
      v2: add comments inside and modify commit messages.
      
      [  +2.180243] [drm] psp gfx command ID_LOAD_TOC(0x20) failed
      and response status is (0x0)
      [  +0.000011] [drm:psp_hw_start [amdgpu]] *ERROR* Failed to load toc
      [  +0.000890] [drm:psp_hw_start [amdgpu]] *ERROR* PSP tmr init failed!
      [  +0.020683] [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to
      clear memory with ring turned off.
      [  +0.000003] RIP: 0010:amdgpu_bo_release_notify+0x1ef/0x210 [amdgpu]
      [  +0.000004] Call Trace:
      [  +0.000003]  <TASK>
      [  +0.000008]  ttm_bo_release+0x2c4/0x330 [amdttm]
      [  +0.000026]  amdttm_bo_put+0x3c/0x70 [amdttm]
      [  +0.000020]  amdgpu_bo_free_kernel+0xe6/0x140 [amdgpu]
      [  +0.000728]  psp_v11_0_ring_destroy+0x34/0x60 [amdgpu]
      [  +0.000826]  psp_hw_init+0xe7/0x2f0 [amdgpu]
      [  +0.000813]  amdgpu_device_fw_loading+0x1ad/0x2d0 [amdgpu]
      [  +0.000731]  amdgpu_device_init.cold+0x108e/0x2002 [amdgpu]
      [  +0.001071]  ? do_pci_enable_device+0xe1/0x110
      [  +0.000011]  amdgpu_driver_load_kms+0x1a/0x160 [amdgpu]
      [  +0.000729]  amdgpu_pci_probe+0x179/0x3a0 [amdgpu]
      
      Signed-off-by: default avatarlyndonli <Lyndon.Li@amd.com>
      Signed-off-by: default avatarYunxiang Li <Yunxiang.Li@amd.com>
      Reviewed-by: default avatarFeifei Xu <Feifei.Xu@amd.com>
      Reviewed-by: default avatarKenneth Feng <kenneth.feng@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      4eea7fb9
    • lyndonli's avatar
      drm/amdgpu: Fix mode2 reset for sienna cichlid · 74a49415
      lyndonli authored
      
      
      Before this change, sienna_cichlid_get_reset_handler will always
      return NULL, although the module parameter reset_method is 3
      when loading amdgpu driver.
      
      Signed-off-by: default avatarlyndonli <Lyndon.Li@amd.com>
      Signed-off-by: default avatarYunxiang Li <Yunxiang.Li@amd.com>
      Reviewed-by: default avatarFeifei Xu <Feifei.Xu@amd.com>
      Reviewed-by: default avatarKenneth Feng <kenneth.feng@amd.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      74a49415
  2. Apr 27, 2023
  3. Apr 19, 2023
  4. Apr 17, 2023
    • Dave Airlie's avatar
      Merge tag 'amd-drm-next-6.4-2023-04-14' of https://gitlab.freedesktop.org/agd5f/linux into drm-next · e82c98f2
      Dave Airlie authored
      
      
      amd-drm-next-6.4-2023-04-14:
      
      amdgpu:
      - S4 fixes for APUs
      - GFX11 fixes
      - Misc code cleanups
      - DCN 3.2 fixes
      - DCN 3.1.4 fixes
      - FPO/FAMS work to improve display power savings
      - DP fixes
      - UMC 8.10 code cleanup
      - SDMA v4 fix
      - GPU clock counter fixes
      - SMU 13 fixes
      - Sdma v6 invalidation fix for preemption
      - RAS fixes
      - S0ix fix
      - GC 9.4.3 updates
      
      amdkfd:
      - Fix user pointers with IOMMU
      - Fix coherency flag handling
      
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Alex Deucher <alexander.deucher@amd.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20230414204609.7942-1-alexander.deucher@amd.com
      e82c98f2
  5. Apr 15, 2023