Skip to content
Commit f207dbe6 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

Revert "sched/wait: Suppress Sparse 'variable shadowing' warning"

This reverts commit 980f88e4

.

This warning is actually useful, don't suppress it.

We actually rely on the shadowing for ___wait_cond_timeout().

We further used the __ret variable in __wait_event_timeout()'s cmd
argument: __ret = schedule_timeout(__ret). That now explicitly uses the
wrong __ret.

Reported-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
Requested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Requested-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-Q5blhuqqzwgVwvjf1gszrdol@git.kernel.org
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 47be1c1a
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment