Skip to content
Commit ede03d30 authored by Alan Cox's avatar Alan Cox Committed by David S. Miller
Browse files

ser_gigaset: turn nonsense checks into WARN_ON



These checks do nothing useful to protect the code from races. On the
other hand if the old code has been masking a real bug we would like to
know about it.

The check for tiocmset is kept because it is valid for a tty driver to
have a NULL tiocmset method. That in itself is probably a mistake given
modern coding practices - but needs fixing in the tty layer.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Acked-by: default avatarTilman Schmidt <tilman@imap.cc>
Signed-off-by: default avatarPaul Bolle <pebolle@tiscali.nl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 74375c05
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment