Skip to content
Commit c7a7b814 authored by Tim Gardner's avatar Tim Gardner Committed by Ingo Molnar
Browse files

ioremap: Delay sanity check until after a successful mapping



While tracking down the reason for an ioremap() failure I was
distracted  by the WARN_ONCE() in __ioremap_caller().

Performing a WARN_ONCE() sanity check before the mapping
is successful seems pointless if the caller sends bad values.

A case in point is when the BIOS provides erroneous screen_info
values causing vesafb_probe() to request an outrageuous size.
The WARN_ONCE is then wasted on bogosity. Move the warning to a
point where the mapping has been successfully allocated.

Addresses:

  http://bugs.launchpad.net/bugs/772042

Reviewed-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
Link: http://lkml.kernel.org/r/4DB99D2E.9080106@canonical.com
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 64d21fc1
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment