Skip to content
Commit b5292111 authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Jens Axboe
Browse files

libata: Use per port sync for detach



Commit 130f4caf ("libata: Ensure ata_port probe has completed before
detach") may cause system freeze during suspend.

Using async_synchronize_full() in PM callbacks is wrong, since async
callbacks that are already scheduled may wait for not-yet-scheduled
callbacks, causes a circular dependency.

Instead of using big hammer like async_synchronize_full(), use async
cookie to make sure port probe are synced, without affecting other
scheduled PM callbacks.

Fixes: 130f4caf ("libata: Ensure ata_port probe has completed before detach")
Suggested-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: default avatarJohn Garry <john.garry@huawei.com>
BugLink: https://bugs.launchpad.net/bugs/1867983


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f650ef61
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment