Skip to content
Commit a6f26606 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alexandre Belloni
Browse files

rtc: rv3029: revert error handling patch to rv3029_eeprom_write()



My error handling "cleanup" was totally wrong.  Both the "err" and "ret"
variables are required.  The "err" variable holds the error codes for
rv3029_eeprom_enter/exit() and the "ret" variable holds the error codes
for if actual write fails.  In my patch if the write failed, the
function probably still returned success.

Reported-by: default avatarTom Evans <tom.evans@motec.com.au>
Fixes: 97f5b037 ("rtc: rv3029: Clean up error handling in rv3029_eeprom_write()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190817065604.GB29951@mwanda


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 80ba9363
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment