Skip to content
Commit 9220c3ef authored by Jinghao Jia's avatar Jinghao Jia Committed by Alexei Starovoitov
Browse files

samples/bpf: syscall_tp_user: Fix array out-of-bound access

Commit 06744f24 ("samples/bpf: Add openat2() enter/exit tracepoint
to syscall_tp sample") added two more eBPF programs to support the
openat2() syscall. However, it did not increase the size of the array
that holds the corresponding bpf_links. This leads to an out-of-bound
access on that array in the bpf_object__for_each_program loop and could
corrupt other variables on the stack. On our testing QEMU, it corrupts
the map1_fds array and causes the sample to fail:

  # ./syscall_tp
  prog #0: map ids 4 5
  verify map:4 val: 5
  map_lookup failed: Bad file descriptor

Dynamically allocate the array based on the number of programs reported
by libbpf to prevent similar inconsistencies in the future

Fixes: 06744f24

 ("samples/bpf: Add openat2() enter/exit tracepoint to syscall_tp sample")
Signed-off-by: default avatarJinghao Jia <jinghao@linux.ibm.com>
Signed-off-by: default avatarRuowen Qin <ruowenq2@illinois.edu>
Signed-off-by: default avatarJinghao Jia <jinghao7@illinois.edu>
Link: https://lore.kernel.org/r/20230917214220.637721-4-jinghao7@illinois.edu
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 0ee352fe
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment