Skip to content
Commit 778d226a authored by Brian Norris's avatar Brian Norris
Browse files

mtd: m25p80: fix allocation size



This patch fixes two memory errors:

1. During a probe failure (in mtd_device_parse_register?) the command
   buffer would not be freed.

2. The command buffer's size is determined based on the 'fast_read'
   boolean, but the assignment of fast_read is made after this
   allocation. Thus, the buffer may be allocated "too small".

To fix the first, just switch to the devres version of kzalloc.

To fix the second, increase MAX_CMD_SIZE unconditionally. It's not worth
saving a byte to fiddle around with the conditions here.

This problem was reported by Yuhang Wang a while back.

Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Reported-by: default avatarYuhang Wang <wangyuhang2014@gmail.com>
Reviewed-by: default avatarSourav Poddar <sourav.poddar@ti.com>
Cc: <stable@vger.kernel.org>
parent 7caa4fd2
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment