Skip to content
Commit 4860abb9 authored by Steve French's avatar Steve French
Browse files

smb: Fix regression in writes when non-standard maximum write size negotiated



The conversion to netfs in the 6.3 kernel caused a regression when
maximum write size is set by the server to an unexpected value which is
not a multiple of 4096 (similarly if the user overrides the maximum
write size by setting mount parm "wsize", but sets it to a value that
is not a multiple of 4096).  When negotiated write size is not a
multiple of 4096 the netfs code can skip the end of the final
page when doing large sequential writes, causing data corruption.

This section of code is being rewritten/removed due to a large
netfs change, but until that point (ie for the 6.3 kernel until now)
we can not support non-standard maximum write sizes.

Add a warning if a user specifies a wsize on mount that is not
a multiple of 4096 (and round down), also add a change where we
round down the maximum write size if the server negotiates a value
that is not a multiple of 4096 (we also have to check to make sure that
we do not round it down to zero).

Reported-by: default avatarR. Diez" <rdiez-2006@rd10.de>
Fixes: d08089f6

 ("cifs: Change the I/O paths to use an iterator rather than a page list")
Suggested-by: default avatarRonnie Sahlberg <ronniesahlberg@gmail.com>
Acked-by: default avatarRonnie Sahlberg <ronniesahlberg@gmail.com>
Tested-by: default avatarMatthew Ruffell <matthew.ruffell@canonical.com>
Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
Cc: stable@vger.kernel.org # v6.3+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 8bde59b2
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment