Skip to content
Commit 387125fc authored by Chris Mason's avatar Chris Mason
Browse files

Btrfs: fix barrier flushes



When btrfs is writing the super blocks, it send barrier flushes to make
sure writeback caching drives get all the metadata on disk in the
right order.

But, we have two bugs in the way these are sent down.  When doing
full commits (not via the tree log), we are sending the barrier down
before the last super when it should be going down before the first.

In multi-device setups, we should be waiting for the barriers to
complete on all devices before writing any of the supers.

Both of these bugs can cause corruptions on power failures.  We fix it
with some new code to send down empty barriers to all devices before
writing the first super.

Alexandre Oliva found the multi-device bug.  Arne Jansen did the async
barrier loop.

Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
Reported-by: default avatarAlexandre Oliva <oliva@lsd.ic.unicamp.br>
parent f1ebcc74
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment