Skip to content
Commit 02c03a32 authored by Luca Tettamanti's avatar Luca Tettamanti Committed by Avi Kivity
Browse files

KVM: Fix x86 emulator writeback



When the old value and new one are the same the emulator skips the
write; this is undesirable when the destination is a MMIO area and the
write shall be performed regardless of the previous value. This
optimization breaks e.g. a Linux guest APIC compiled without
X86_GOOD_APIC.

Remove the check and perform the writeback stage in the emulation unless
it's explicitly disabled (currently push and some 2 bytes instructions
may disable the writeback).

Signed-Off-By: default avatarLuca Tettamanti <kronos.it@gmail.com>
Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent 74906345
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment