Skip to content
  1. May 23, 2014
  2. May 19, 2014
  3. May 16, 2014
  4. May 15, 2014
  5. May 09, 2014
    • Fabian Frederick's avatar
      fbdev: fbmem: remove positive test on unsigned values · 34bdb666
      Fabian Frederick authored
      
      
      fb_image.dx, fb_image.dy and fbconf2bmap.framebuffer are __u32
      
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      34bdb666
    • Masami Ichikawa's avatar
      fbcon: Fix memory leak in con2fb_release_oldinfo() · 7a966fbd
      Masami Ichikawa authored
      
      
      kmemleak reported a memory leak as below.
      
      unreferenced object 0xffff8800dab6d8d8 (size 96):
        comm "swapper/0", pid 1, jiffies 4294877598 (age 38.483s)
        hex dump (first 32 bytes):
          00 00 00 00 00 01 00 00 08 00 00 00 10 00 00 00  ................
          07 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
        backtrace:
          [<ffffffff814e8f2e>] kmemleak_alloc+0x4e/0xb0
          [<ffffffff811a0600>] __kmalloc+0x280/0x320
          [<ffffffff81309b61>] soft_cursor+0x231/0x290
          [<ffffffff81309393>] bit_cursor+0x613/0x650
          [<ffffffff8130556b>] fbcon_cursor+0x13b/0x1c0
          [<ffffffff813755f8>] hide_cursor+0x28/0xa0
          [<ffffffff81376e98>] redraw_screen+0x168/0x240
          [<ffffffff81303891>] fbcon_prepare_logo+0x381/0x420
          [<ffffffff81303c7e>] fbcon_init+0x34e/0x590
          [<ffffffff81375828>] visual_init+0xb8/0x120
          [<ffffffff81377c93>] do_bind_con_driver+0x163/0x380
          [<ffffffff81378494>] do_take_over_console+0x114/0x1c0
          [<ffffffff81303f23>] do_fbcon_takeover+0x63/0xd0
          [<ffffffff813086dd>] fbcon_event_notify+0x68d/0x7e0
          [<ffffffff814ff7ac>] notifier_call_chain+0x4c/0x70
          [<ffffffff8108c85d>] __blocking_notifier_call_chain+0x4d/0x70
      
      This memory leak cause is, fbcon_ops's cursor_src is allocated in
      soft_cursor() but not released in con2fb_release_oldinfo().
      so, cursor_src is needed to be released when oldinfo is going to be
      released.
      
      Signed-off-by: default avatarMasami Ichikawa <masami256@gmail.com>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      7a966fbd
    • Jean Delvare's avatar
      video: Kconfig: Add a dependency to the Goldfish framebuffer driver · 632de707
      Jean Delvare authored
      
      
      All other Goldfish drivers depend on GOLDFISH, I see no reason why the
      framebuffer driver would be an exception.
      
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      632de707
    • Jean Delvare's avatar
      video: exynos: Add a dependency to the menu · 5fb7652b
      Jean Delvare authored
      
      
      All drivers under menu EXYNOS_VIDEO depend on either ARCH_S5PV210 or
      ARCH_EXYNOS, so add these as dependencies to the menu itself. This
      avoids presenting an empty and useless menu on other architectures.
      
      Then drivers under the menu only need a dependency if they depend on
      one of the supported architectures specifically.
      
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: Kukjin Kim <kgene.kim@samsung.com>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      5fb7652b
    • Denis Carikli's avatar
      video: mx3fb: Use devm_kzalloc · c58f6616
      Denis Carikli authored
      
      
      Replace kzalloc by devm_kzalloc and remove the kfree() calls.
      
      Signed-off-by: default avatarDenis Carikli <denis@eukrea.com>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      c58f6616
    • Arnd Bergmann's avatar
      video/nuc900: allow modular build · e3e11f51
      Arnd Bergmann authored
      
      
      The frame buffer core may be a loadable module, and in this
      case, the nuc900 driver cannot be built-in. Turning it into
      a tristate option lets Kconfig work out the dependency and
      avoid broken builds.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Cc: Wan ZongShun <mcuos.com@gmail.com>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      e3e11f51
    • Arnd Bergmann's avatar
      video: atmel needs FB_BACKLIGHT · 3cdd1537
      Arnd Bergmann authored
      
      
      The atmel frame buffer driver doesn't build if FB_BACKLIGHT
      is disabled, so select it here as we do for lots of other
      drivers.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      3cdd1537
    • Arnd Bergmann's avatar
      video: export fb_prepare_logo · 23e51f87
      Arnd Bergmann authored
      
      
      Some drivers that may be loadable modules use the fb_prepare_logo
      function, so we have to export it. Found during randconfig
      builds with mmpfb.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      23e51f87
    • Arnd Bergmann's avatar
      video/mbx: fix building debugfs support · fabd3152
      Arnd Bergmann authored
      
      
      The mbx framebuffer debugfs support apparently hasn't been able
      to build for a long time, at least since 2006 when the u.generic_ip
      field in the inode was removed. This fixes the obvious bug, and
      also makes it possible to build the driver as a module when
      debugfs support is enabled, by simply including the C file.
      It's ugly, but it won't make the driver any worse than it
      already is, and doesn't require a more invasive change that
      might break it further.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Cc: Raphael Assenat <raph@8d.com>
      Cc: Mike Rapoport <mike@compulab.co.il>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      fabd3152
    • Arnd Bergmann's avatar
      video/omap: fix modular build · 81c44c2b
      Arnd Bergmann authored
      
      
      The framebuffer layer can be a loadable module, which forces
      omapfb to be a module as well. However, this breaks the lcd
      drivers, which are linked into the omapfb driver but each
      have their own module_init() function. To solve this,
      we split out the lcd drivers into separate modules and
      export omapfb_register_panel, which is the only interface
      required between the main omapfb driver and the lcd panel
      drivers.
      
      We also have to introduce a new Kconfig symbol for H3, since
      that lcd driver has a dependency on TPS65010, which we can
      express better in Kconfig than Makefile syntax.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Cc: linux-omap@vger.kernel.org
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      81c44c2b
    • Arnd Bergmann's avatar
      video: clarify I2C dependencies · f7200b68
      Arnd Bergmann authored
      
      
      We can only use I2C support in frame buffer drivers if
      Either I2C is built-in, or both I2C and the driver itself
      are loadable modules.
      
      Fix this dependency for MB862XX and CyberPro frame buffers.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Cc: Russell King <linux@arm.linux.org.uk>
      Cc: Anatolij Gustschin <agust@denx.de>
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      f7200b68
  6. May 07, 2014
    • Arnd Bergmann's avatar
      video: sh_mobile_lcdcfb depends on meram · 423431a3
      Arnd Bergmann authored
      
      
      The sh_mobile_lcdcfb driver calls interfaces provided
      by the corresponding "meram" helper. This fails if meram
      is a module but lcdcfb is built-in.
      
      To work around it, this uses special Kconfig magic to
      only allow lcdcfb to be built if
      a) both are modules,
      b) meram is built-in, or
      c) meram is disabled and the helpers stubbed out
      
      Changing meram from 'y' to 'm' now forces clcd to
      be a module as well, which seems to be the desired
      behavior.
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
      Cc: Simon Horman <horms+renesas@verge.net.au>
      Cc: Magnus Damm <magnus.damm@gmail.com>
      Cc: linux-sh@vger.kernel.org
      Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: linux-fbdev@vger.kernel.org
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      423431a3
  7. May 02, 2014
  8. Apr 30, 2014
  9. Apr 22, 2014
  10. Apr 21, 2014
  11. Apr 20, 2014
    • Ingo Molnar's avatar
      Merge tag 'perf-urgent-for-mingo' of... · fd741edc
      Ingo Molnar authored
      Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf
      
       into perf/urgent
      
      Pull perf/urgent fixes from Jiri Olsa:
      
      User visible changes:
      
        * Adjust symbols in VDSO to properly resolve its function names (Vladimir Nikulichev)
      
        * Improve error reporting for record session failure (Adrien BAK)
      
        * Fix 'Min time' counting in report command (Alexander Yarygin)
      
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      fd741edc
    • Adrien BAK's avatar
      perf tools: Improve error reporting · ffa91880
      Adrien BAK authored
      In the current version, when using perf record, if something goes
      wrong in tools/perf/builtin-record.c:375
        session = perf_session__new(file, false, NULL);
      
      The error message:
      "Not enough memory for reading per file header"
      
      is issued. This error message seems to be outdated and is not very
      helpful. This patch proposes to replace this error message by
      "Perf session creation failed"
      
      I believe this issue has been brought to lkml:
      https://lkml.org/lkml/2014/2/24/458
      
      
      although this patch only tackles a (small) part of the issue.
      
      Additionnaly, this patch improves error reporting in
      tools/perf/util/data.c open_file_write.
      
      Currently, if the call to open fails, the user is unaware of it.
      This patch logs the error, before returning the error code to
      the caller.
      
      Reported-by: default avatarWill Deacon <will.deacon@arm.com>
      Signed-off-by: default avatarAdrien BAK <adrien.bak@metascale.org>
      Link: http://lkml.kernel.org/r/1397786443.3093.4.camel@beast
      
      
      [ Reorganize the changelog into paragraphs ]
      [ Added empty line after fd declaration in open_file_write ]
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      ffa91880
    • Vladimir Nikulichev's avatar
      perf tools: Adjust symbols in VDSO · 922d0e4d
      Vladimir Nikulichev authored
      
      
      pert-report doesn't resolve function names in VDSO:
      
      $ perf report --stdio -g flat,0.0,15,callee --sort pid
      ...
                  8.76%
                     0x7fff6b1fe861
                     __gettimeofday
                     ACE_OS::gettimeofday()
      ...
      
      In this case symbol values should be adjusted the same way as for executables,
      relocatable objects and prelinked libraries.
      
      After fix:
      
      $ perf report --stdio -g flat,0.0,15,callee --sort pid
      ...
                  8.76%
                     __vdso_gettimeofday
                     __gettimeofday
                     ACE_OS::gettimeofday()
      
      Signed-off-by: default avatarVladimir Nikulichev <nvs@tbricks.com>
      Tested-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Link: http://lkml.kernel.org/r/969812.163009436-sendEmail@nvs
      
      
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      922d0e4d
    • Alexander Yarygin's avatar
      perf kvm: Fix 'Min time' counting in report command · acb61fc8
      Alexander Yarygin authored
      
      
      Every event in the perf-kvm has a 'stats' structure, which contains
      max/min/average/etc times of handling this event.
      The problem is that the 'perf-kvm stat report' command always shows
      that 'min time' is 0us for every event. Example:
      
       # perf kvm stat report
      
       Analyze events for all VCPUs:
      
          VM-EXIT    Samples  Samples%     Time%   Min Time   Max Time Avg time
        [..]
        0xB2 MSCH         12     0.07%     0.00%        0us        8us 7.31us ( +-   2.11% )
        0xB2 CHSC         12     0.07%     0.00%        0us       18us 9.39us ( +-   9.49% )
        0xB2 STPX          8     0.05%     0.00%        0us        2us 1.88us ( +-   7.18% )
        0xB2 STSI          7     0.04%     0.00%        0us       44us 16.49us ( +-  38.20% )
        [..]
      
      This happens because the 'stats' structure is not initialized and
      stats->min equals to 0. Lets initialize the structure for every
      event after its allocation using init_stats() function. This initializes
      stats->min to -1 and makes 'Min time' statistics counting work:
      
       # perf kvm stat report
      
       Analyze events for all VCPUs:
      
          VM-EXIT    Samples  Samples%     Time%   Min Time   Max Time Avg time
        [..]
        0xB2 MSCH         12     0.07%     0.00%        6us        8us 7.31us ( +-   2.11% )
        0xB2 CHSC         12     0.07%     0.00%        7us       18us 9.39us ( +-   9.49% )
        0xB2 STPX          8     0.05%     0.00%        1us        2us 1.88us ( +-   7.18% )
        0xB2 STSI          7     0.04%     0.00%        1us       44us 16.49us ( +-  38.20% )
        [..]
      
      Signed-off-by: default avatarAlexander Yarygin <yarygin@linux.vnet.ibm.com>
      Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
      Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
      Link: http://lkml.kernel.org/r/1397053319-2130-3-git-send-email-borntraeger@de.ibm.com
      
      
      [ Fixing the perf examples changelog output ]
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      acb61fc8
    • Eric Dumazet's avatar
      coredump: fix va_list corruption · 404ca80e
      Eric Dumazet authored
      
      
      A va_list needs to be copied in case it needs to be used twice.
      
      Thanks to Hugh for debugging this issue, leading to various panics.
      
      Tested:
      
        lpq84:~# echo "|/foobar12345 %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h" >/proc/sys/kernel/core_pattern
      
      'produce_core' is simply : main() { *(int *)0 = 1;}
      
        lpq84:~# ./produce_core
        Segmentation fault (core dumped)
        lpq84:~# dmesg | tail -1
        [  614.352947] Core dump to |/foobar12345 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 lpq84 (null) pipe failed
      
      Notice the last argument was replaced by a NULL (we were lucky enough to
      not crash, but do not try this on your production machine !)
      
      After fix :
      
        lpq83:~# echo "|/foobar12345 %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h %h" >/proc/sys/kernel/core_pattern
        lpq83:~# ./produce_core
        Segmentation fault
        lpq83:~# dmesg | tail -1
        [  740.800441] Core dump to |/foobar12345 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 lpq83 pipe failed
      
      Fixes: 5fe9d8ca ("coredump: cn_vprintf() has no reason to call vsnprintf() twice")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Diagnosed-by: default avatarHugh Dickins <hughd@google.com>
      Acked-by: default avatarOleg Nesterov <oleg@redhat.com>
      Cc: Neil Horman <nhorman@tuxdriver.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: stable@vger.kernel.org # 3.11+
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      404ca80e