Skip to content
  1. Apr 18, 2024
  2. Apr 07, 2024
  3. Apr 05, 2024
    • Takashi Iwai's avatar
      Merge tag 'asoc-fix-v6.9-rc2' of... · 100c8542
      Takashi Iwai authored
      Merge tag 'asoc-fix-v6.9-rc2' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
      
      ASoC: Fixes for v6.9
      
      A relatively large set of fixes here, the biggest piece of it is a
      series correcting some problems with the delay reporting for Intel SOF
      cards but there's a bunch of other things.  Everything here is driver
      specific except for a fix in the core for an issue with sign extension
      handling volume controls.
      100c8542
    • Chaitanya Kumar Borah's avatar
      ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path · 90f8917e
      Chaitanya Kumar Borah authored
      
      
      In cases where the sof driver is unable to find the firmware and/or
      topology file [1], it exits without releasing the i915 runtime
      pm wakeref [2]. This results in dmesg warnings[3] during
      suspend/resume or driver unbind. Add remove_late() to the failure path
      of sof_init_environment so that i915 wakeref is released appropriately
      
      [1]
      
      [    8.990366] sof-audio-pci-intel-mtl 0000:00:1f.3: SOF firmware and/or topology file not found.
      [    8.990396] sof-audio-pci-intel-mtl 0000:00:1f.3: Supported default profiles
      [    8.990398] sof-audio-pci-intel-mtl 0000:00:1f.3: - ipc type 1 (Requested):
      [    8.990399] sof-audio-pci-intel-mtl 0000:00:1f.3:  Firmware file: intel/sof-ipc4/mtl/sof-mtl.ri
      [    8.990401] sof-audio-pci-intel-mtl 0000:00:1f.3:  Topology file: intel/sof-ace-tplg/sof-mtl-rt711-2ch.tplg
      [    8.990402] sof-audio-pci-intel-mtl 0000:00:1f.3: Check if you have 'sof-firmware' package installed.
      [    8.990403] sof-audio-pci-intel-mtl 0000:00:1f.3: Optionally it can be manually downloaded from:
      [    8.990404] sof-audio-pci-intel-mtl 0000:00:1f.3:    https://github.com/thesofproject/sof-bin/
      [    8.999088] sof-audio-pci-intel-mtl 0000:00:1f.3: error: sof_probe_work failed err: -2
      
      [2]
      
      ref_tracker: 0000:00:02.0@ffff9b8511b6a378 has 1/5 users at
           track_intel_runtime_pm_wakeref.part.0+0x36/0x70 [i915]
           __intel_runtime_pm_get+0x51/0xb0 [i915]
           intel_runtime_pm_get+0x17/0x20 [i915]
           intel_display_power_get+0x2f/0x70 [i915]
           i915_audio_component_get_power+0x23/0x120 [i915]
           snd_hdac_display_power+0x89/0x130 [snd_hda_core]
           hda_codec_i915_init+0x3f/0x50 [snd_sof_intel_hda]
           hda_dsp_probe_early+0x170/0x250 [snd_sof_intel_hda_common]
           snd_sof_device_probe+0x224/0x320 [snd_sof]
           sof_pci_probe+0x15b/0x220 [snd_sof_pci]
           hda_pci_intel_probe+0x30/0x70 [snd_sof_intel_hda_common]
           local_pci_probe+0x4c/0xb0
           pci_device_probe+0xcc/0x250
           really_probe+0x18e/0x420
           __driver_probe_device+0x7e/0x170
           driver_probe_device+0x23/0xa0
      
      [3]
      [  484.105070] ------------[ cut here ]------------
      [  484.108238] thunderbolt 0000:00:0d.2: PM: pci_pm_suspend_late+0x0/0x50 returned 0 after 0 usecs
      [  484.117106] i915 0000:00:02.0: i915 raw-wakerefs=1 wakelocks=1 on cleanup
      [  484.792005] WARNING: CPU: 2 PID: 2405 at drivers/gpu/drm/i915/intel_runtime_pm.c:444 intel_runtime_pm_driver_release+0x6c/0x80
      
      Tested-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
      Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
      Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
      Signed-off-by: default avatarChaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Link: https://github.com/thesofproject/linux/pull/4878
      Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
      Link: https://msgid.link/r/20240404184813.134566-1-pierre-louis.bossart@linux.intel.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      90f8917e
  4. Apr 04, 2024
  5. Apr 03, 2024
  6. Apr 02, 2024
  7. Apr 01, 2024
  8. Mar 30, 2024
  9. Mar 29, 2024
  10. Mar 28, 2024
  11. Mar 27, 2024
  12. Mar 26, 2024
    • Mark Brown's avatar
      ASoC: SOF: ipc4/Intel: Fix delay reporting · 3849c4d6
      Mark Brown authored
      Merge series from Peter Ujfalusi <peter.ujfalusi@linux.intel.com>:
      
      The current version of delay reporting code can report incorrect
      values when paired with a firmware which enables this feature.
      
      Unfortunately there are several smaller issues that needed to be addressed
      to correct the behavior:
      
      Wrong information was used for the host side of counter
      For MTL/LNL used incorrect (in a sense that it was verified only on MTL)
      link side counter function.
      The link side counter needs compensation logic if pause/resume is used.
      The offset values were not refreshed from firmware.
      Finally, not strictly connected, but the ALSA buffer size needs to be
      constrained to avoid constant xrun from media players (like mpv)
      
      The series applies cleanly for 6.9 and 6.8.y stable, but older stable
      would need manual backport, but it is questionable if it is needed as
      MTL/LNL is missing features.
      3849c4d6